Created attachment 2353 [details] Patch to implement the feature Hi, I submitted this a few weeks ago to the mailing list but got no response so I resent it and am putting it here so it doesn't get lost. This patch implements SSH2_FXF_APPEND in the sftp server. It is a fairly trivial patch and applies against the proper OpenSSH and the Portable edition. I would argue that it is important for OpenSSH to implement SSH2_FXF_APPEND since it is in the spec and clients who expect it to work find that their files are overwritten rather than appended to. Some relevant links: http://marc.info/?l=openssh-unix-dev&m=138053388830753&w=2 http://marc.info/?l=openssh-unix-dev&m=123798287811788 http://marc.info/?l=openssh-unix-dev&m=111093206900604 https://bugzilla.gnome.org/show_bug.cgi?id=608910 Thanks
looks reasonable.
As far as I can tell this has been commited. Closing as fixed.
No, this hasn't been committed yet. Please don't close the bug until it is.
(In reply to Damien Miller from comment #3) > No, this hasn't been committed yet. Please don't close the bug until > it is. Sorry. I thought it was committed because it seems to have committed in revision 101 over here: http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/sftp-server.c.diff?r1=1.100;r2=1.101 The commit message for that seems to be unrelated though: """ refactor client config code a little: add multistate option partsing to readconf.c, similar to servconf.c's existing code. move checking of options that accept "none" as an argument to readconf.c add a lowercase() function and use it instead of explicit tolower() in loops part of a larger diff that was ok markus@ """
ha, you're correct. I'd sent the patch out for review, but must have forgotten it was in my tree when committing something unrelated.
Close all resolved bugs after 7.3p1 release