Bug 2345 - NESTING_INDENT_MISMATCH: missing parenthesis around if body in ssh-keygen.c:724
Summary: NESTING_INDENT_MISMATCH: missing parenthesis around if body in ssh-keygen.c:724
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-keygen (show other bugs)
Version: 6.7p1
Hardware: Other Linux
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_6_8
  Show dependency tree / graph
 
Reported: 2015-01-30 01:38 AEDT by Jakub Jelen
Modified: 2015-03-18 18:17 AEDT (History)
1 user (show)

See Also:

Attachments
patch (497 bytes, text/plain)
2015-01-30 01:38 AEDT, Jakub Jelen 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Jelen 2015-01-30 01:38:42 AEDT 
Created attachment 2538 [details]
patch

Our coverity scan on openssh found one defect - body of function in above mentioned line is not in parenthesis so it doesn't do what it is supposed to do or if it does, it is pretty confusing by the indentation.

It probably does what it is supposed to do, because sshkey_write probably fails with private key, but I wouldn't rely on it.

This problem is there quite long, since 44b25040110a224a79ff371ee548be9a10ba8bfa, Fri Jul 2 13:35:01 2010

For patch (demonstration) see attachment.
Comment 1 Damien Miller 2015-01-30 12:00:58 AEDT 
Applied - will be in openssh-6.8. Thanks!
Comment 2 Damien Miller 2015-03-18 18:17:08 AEDT 
openssh-6.8 is released