Bug 2350 - ssh-copy-id doesn't handle keys with missing trailing newline
Summary: ssh-copy-id doesn't handle keys with missing trailing newline
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-copy-id (show other bugs)
Version: 6.7p1
Hardware: Other Linux
: P5 enhancement
Assignee: Philip Hands
URL:
Keywords:
Depends on:
Blocks: V_7_2
  Show dependency tree / graph
 
Reported: 2015-02-12 21:17 AEDT by Jakub Jelen
Modified: 2021-04-23 15:10 AEST (History)
1 user (show)

See Also:

Attachments
patch (854 bytes, patch)
2015-02-12 21:17 AEDT, Jakub Jelen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Jelen 2015-02-12 21:17:08 AEDT 
Created attachment 2548 [details]
patch

One our user ran into problem with missing trailing newline characters in public key file when copying to remote server [1]. Everyone knows that every text file should end with newline character, but tools should handle both as ssh, sshd and other tools do.

I know that this is not major issue and you are working on more important stuff, but this can help usability and avoid confusion if there are some old or malformed keys.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1093168
Comment 1 Philip Hands 2015-11-29 06:37:16 AEDT 
Thanks for the patch, and sorry for the time it's take for me to get to it. I've applied it to my git repo:

  http://git.hands.com/?p=ssh-copy-id.git;a=commit;h=de78897ada50ed12f4b0c9faa6e935ce82ee49a6

so hopefully that will make it's way into OpenSSH soon.

Cheers, Phil.
Comment 2 Damien Miller 2021-04-23 15:10:59 AEST 
closing resolved bugs as of 8.6p1 release