Created attachment 2577 [details] patch During some playing around with openss-6.8 I found one memory leak in server. This was introduced in https://anongit.mindrot.org/openssh.git/commit/?id=5ecb41629860687b145be63b8877fabb6bae5eda It happened that you are not freeing allocated string with local_ipaddr. This is nothing critical, but nice to have. Patch is quite simple (see attachment).
Comment on attachment 2577 [details] patch >- get_local_ipaddr(sock_in), get_local_port()); >+ (addr = get_local_ipaddr(sock_in)), get_local_port()); I think it'd be cleaner to do that assignment on a separate line rather than buried in the format string args. >+ xfree(addr); What version did you test this against? xfree() is long gone.
Created attachment 2586 [details] revised patch Thanks for comments. I was fixing this in recently released 6.8, but I don't know why I posted here xfree. Probably slow switching of context from fixing similar issue in older versions. Adding revised patch with morning insight.
I just committed a slightly modified version of this patch and it'll be in the 6.9 release. Thanks.
Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1