Created attachment 2670 [details]
Do not require to return ID from token

Based on our investigation of Smart Cart usability with openSSH we found several minor problems that were filled in our red hat bugzilla [1]. The another is problem again with softHSM. It is returning empty ID, which is not handled by keygen correctly.

The length check was added based on the bug #1773. It is fine to skip certificates that have empty values. But requiring non-empty ID is not preferred way because:
 * the ID is not used anywhere in ssh-keygen
 * some tokens do not provide ID

The example is again softHSM2 token, which returns ID length of zero and in current ssh-keygen is silently ignored.
This token has also the need to login, before even public key can be accessed (not rare example), but it will be described in other report, since it will require more changes.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=1241873