Bug 2441 - compat listing for WinSCP
Summary: compat listing for WinSCP
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: -current
Hardware: Other All
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_1
  Show dependency tree / graph
 
Reported: 2015-08-06 11:05 AEST by Damien Miller
Modified: 2016-08-02 10:42 AEST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Damien Miller 2015-08-06 11:05:09 AEST 
Older versions of WinSCP don't implement RFC4419-style DH-GEX. WinSCP developer Martin Prikryl provided this list of versions:

> > WinSCP_release_4*
> > WinSCP_release_5.0*
> > WinSCP_release_5.1*
> > WinSCP_release_5.2*
> > WinSCP_release_5.5*
> > WinSCP_release_5.6*
> > WinSCP_release_5.7
> > WinSCP_release_5.7.1
> > WinSCP_release_5.7.2
> > WinSCP_release_5.7.3
> > WinSCP_release_5.7.4

We need to add these to compat.c with SSH_OLD_DHGEX
Comment 1 Martin Prikryl 2015-08-06 16:27:37 AEST 
Thanks for submitting the bug.

WinSCP is already in compat.c unconditionally (WinSCP*).
https://anongit.mindrot.org/openssh.git/commit/compat.c?id=b58234f00ee3872eb84f6e9e572a9a34e902e36e

Please update the rule to these specific versions only:

WinSCP_release_4*
WinSCP_release_5.0
WinSCP_release_5.0.*
WinSCP_release_5.1
WinSCP_release_5.1.*
WinSCP_release_5.5
WinSCP_release_5.5.*
WinSCP_release_5.6
WinSCP_release_5.6.*
WinSCP_release_5.7
WinSCP_release_5.7.1
WinSCP_release_5.7.2
WinSCP_release_5.7.3
WinSCP_release_5.7.4

(my original list, as submitted by Damien, was not correct from a forward compatibility perspective)

Thanks in advance!

Reference:
http://winscp.net/tracker/show_bug.cgi?id=1345
Comment 2 Damien Miller 2015-09-04 13:28:39 AEST 
This was fixed and included in openssh-7.1. Thanks!
Comment 3 Martin Prikryl 2015-09-04 16:54:08 AEST 
Thanks!
Comment 4 Damien Miller 2016-08-02 10:42:02 AEST 
Close all resolved bugs after 7.3p1 release