Bug 2459 - ssh-keygen -t rsa1 should be removed from Makefile
Summary: ssh-keygen -t rsa1 should be removed from Makefile
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: 7.1p1
Hardware: All All
: P5 trivial
Assignee: Darren Tucker
URL:
Keywords:
Depends on:
Blocks: V_7_2
  Show dependency treegraph
 
Reported: 2015-09-08 01:38 AEST by Lőrinczy Zsigmond
Modified: 2016-08-02 10:40 AEST (History)
3 users (show)

See Also:


Attachments
test for protocol v.1 support before generating rsa1 key (517 bytes, patch)
2015-09-11 13:25 AEST, Damien Miller
no flags Details | Diff
use "ssh-keygen -A", add tests to host-key-force (2.17 KB, patch)
2015-09-11 14:22 AEST, Darren Tucker
no flags Details | Diff
use "ssh-keygen -A", add tests to host-key-force (2.18 KB, patch)
2015-09-11 14:34 AEST, Darren Tucker
djm: ok+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lőrinczy Zsigmond 2015-09-08 01:38:27 AEST
Hi, I've just compiled OpenSSH-7.1 on an AIX machine that didn't have OpenSSH earlier, and got an error about being unable to generate ssh_host_key via 'ssh-keygen -t rsa1' because rsa1 isn't supported any more. (It happens at 'make install')

I suggest removing/changes it to 'ssh-keygen -t rsa'
Comment 1 Damien Miller 2015-09-11 13:25:39 AEST
Created attachment 2697 [details]
test for protocol v.1 support before generating rsa1 key

This should do it
Comment 2 Darren Tucker 2015-09-11 13:37:53 AEST
(In reply to Damien Miller from comment #1)
> Created attachment 2697 [details]
> test for protocol v.1 support before generating rsa1 key
> 
> This should do it

Actually I think we should be switching to ssh-keygen -A, which is more future-proof.
Comment 3 Darren Tucker 2015-09-11 14:22:12 AEST
Created attachment 2698 [details]
use "ssh-keygen -A", add tests to host-key-force
Comment 4 Darren Tucker 2015-09-11 14:34:00 AEST
Created attachment 2699 [details]
use "ssh-keygen -A", add tests to host-key-force

oops, typo.  fixed.
Comment 5 Darren Tucker 2015-09-14 16:27:37 AEST
patch committed and it will be in 7.2p1.  Thanks.
Comment 6 Damien Miller 2016-08-02 10:40:41 AEST
Close all resolved bugs after 7.3p1 release