Bug 2604 - Remove orphaned do_pam_set_tty() or make use of it
Summary: Remove orphaned do_pam_set_tty() or make use of it
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: PAM support (show other bugs)
Version: 7.3p1
Hardware: Other Linux
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_4
  Show dependency tree / graph
 
Reported: 2016-08-16 01:23 AEST by Jakub Jelen
Modified: 2021-04-23 15:11 AEST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Jelen 2016-08-16 01:23:30 AEST 
today I ran into problems with PAM and bumped into the function do_pam_set_tty(), which is defined, but never used, if I see right:

$ git grep do_pam_set_tty
auth-pam.c:do_pam_set_tty(const char *tty)
auth-pam.h:void do_pam_set_tty(const char *);

There is basically duplicate code in sshpam_init(). In the git, last usage of this function was removed in 2008 [1]. I don't think it makes sense to keep it.


[1] https://github.com/openssh/openssh-portable/commit/52358d6d
Comment 1 Darren Tucker 2016-10-15 04:37:11 AEDT 
Done, thanks.
Comment 2 Damien Miller 2021-04-23 15:11:02 AEST 
closing resolved bugs as of 8.6p1 release