Bug 2732 - select() is not called properly in ssh_exchange_identification()
Summary: select() is not called properly in ssh_exchange_identification()
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 7.5p1
Hardware: Other Other
: P5 major
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_6
  Show dependency tree / graph
 
Reported: 2017-06-24 12:11 AEST by balu
Modified: 2021-04-23 14:56 AEST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description balu 2017-06-24 12:11:23 AEST 
I found an issue with select() not called properly in the ssh_exchange_identification().

Variable "fdset" is passed as readfd, exceptionfd to the select().
Select() should be called with independent fdset so we should have two different variables instead of reusing the same variable "fdset".
The reported issue is in line 566, 567 (sshconnect.c file).
Comment 1 Damien Miller 2017-06-24 18:14:33 AEST 
Thanks for reminding me. This has been committed and will be in openssh-7.6

https://anongit.mindrot.org/openssh.git/commit/?id=4540428cd0adf039bcf5a8a27f2d5cdf09191513
Comment 2 Damien Miller 2021-04-23 14:56:30 AEST 
closing resolved bugs as of 8.6p1 release