Bug 2748 - Bug compatibility rules incorrectly match WinSCP 5.10.x
Summary: Bug compatibility rules incorrectly match WinSCP 5.10.x
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: 7.5p1
Hardware: Other Other
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_6
  Show dependency tree / graph
 
Reported: 2017-07-25 05:03 AEST by Martin Prikryl
Modified: 2021-04-23 15:04 AEST (History)
2 users (show)

See Also:

Attachments
Require exact match or dots for older WinSCP versions. (758 bytes, patch)
2017-07-25 09:45 AEST, Darren Tucker 		djm: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Prikryl 2017-07-25 05:03:30 AEST 
The compat_datafellows function in compat.c includes this rule:

		{ "WinSCP_release_4*,"
		  "WinSCP_release_5.0*,"
		  "WinSCP_release_5.1*,"
		  "WinSCP_release_5.5*,"
		  "WinSCP_release_5.6*,"
		  "WinSCP_release_5.7,"
		  "WinSCP_release_5.7.1,"
		  "WinSCP_release_5.7.2,"
		  "WinSCP_release_5.7.3,"
		  "WinSCP_release_5.7.4",
					SSH_OLD_DHGEX },

Unfortunately the "WinSCP_release_5.1*" mask inadvertently matches even the latest branch of WinSCP 5.10 with version string like "WinSCP_release_5.10.4".

Can you please change the masks to require a dot?

		{ "WinSCP_release_4*,"
		  "WinSCP_release_5.0,"
		  "WinSCP_release_5.0.*,"
		  "WinSCP_release_5.1,"
		  "WinSCP_release_5.1.*,"
		  "WinSCP_release_5.5,"
		  "WinSCP_release_5.5.*,"
		  "WinSCP_release_5.6,"
		  "WinSCP_release_5.6.*,"
		  "WinSCP_release_5.7,"
		  "WinSCP_release_5.7.1,"
		  "WinSCP_release_5.7.2,"
		  "WinSCP_release_5.7.3,"
		  "WinSCP_release_5.7.4",
					SSH_OLD_DHGEX },

Thanks.
Comment 1 Darren Tucker 2017-07-25 09:45:05 AEST 
Created attachment 3018 [details]
Require exact match or dots for older WinSCP versions.
Comment 2 Darren Tucker 2017-07-25 09:47:54 AEST 
(In reply to Martin Prikryl from comment #0)
> 		  "WinSCP_release_5.0,"
> 		  "WinSCP_release_5.0.*,"

That one looks unnecessary unless you have versions numbers with leading zeros (which it seems you don't).
Comment 3 Darren Tucker 2017-07-25 09:48:21 AEST 
Could you please confirm the patch does what you want?  Thanks.
Comment 4 Martin Prikryl 2017-07-25 18:01:35 AEST 
(In reply to Darren Tucker from comment #2)
> (In reply to Martin Prikryl from comment #0)
> > 		  "WinSCP_release_5.0,"
> > 		  "WinSCP_release_5.0.*,"
> 
> That one looks unnecessary unless you have versions numbers with
> leading zeros (which it seems you don't).

True. I've added it just for consistency.

(In reply to Darren Tucker from comment #3)

> Could you please confirm the patch does what you want?  Thanks.

There should be a dot, not comma after 1:
"WinSCP_release_5.1,*,"
Like this:
"WinSCP_release_5.1.*,"
Comment 5 Darren Tucker 2017-07-25 19:23:30 AEST 
(In reply to Martin Prikryl from comment #4)
[...]
> There should be a dot, not comma after 1:
> "WinSCP_release_5.1,*,"
> Like this:
> "WinSCP_release_5.1.*,"

Fixed.

Patch applied and will be in 7.6.  Thanks.
Comment 6 Damien Miller 2021-04-23 15:04:36 AEST 
closing resolved bugs as of 8.6p1 release