Bug 2818 - Atari FreeMiNT platform needs patch to openbsd-compat
Summary: Atari FreeMiNT platform needs patch to openbsd-compat
Status: NEW
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 7.6p1
Hardware: 68k Other
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-01-09 19:59 AEDT by Alan Hourihane
Modified: 2018-01-10 21:14 AEDT (History)
0 users

See Also:


Attachments
FreeMiNT patch (1.50 KB, patch)
2018-01-09 19:59 AEDT, Alan Hourihane
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Hourihane 2018-01-09 19:59:11 AEDT
Created attachment 3112 [details]
FreeMiNT patch

Attached.
Comment 1 Darren Tucker 2018-01-10 17:49:07 AEDT
Comment on attachment 3112 [details]
FreeMiNT patch

I don't follow what this is fixing.  It has <sys/statvfs.h> but not statvfs() ?  Could you please show the relevant #defines from config.h on this platform?

Also m68k seriously?  How long does a login take?

> 	/* as defined in IEEE Std 1003.1, 2004 Edition */
>+#if ((!defined(HAVE_STATVFS) && defined(HAVE_STATFS)) || \
>+     (!defined(HAVE_FSTATVFS) && defined(HAVE_FSTATFS)))
> struct statvfs {

If you need to conditionalize this struct I think configure should explicitly check for it, not try to infer it from other definitions.
Comment 2 Alan Hourihane 2018-01-10 21:14:57 AEDT
This is a 68060 running at 100MHz, and it's pretty fast. Login is a second.

Excerpts from the config.h are here...

/* #undef HAVE_FSTATFS */
/* #undef HAVE_FSTATVFS */
/* #undef HAVE_PSTAT */
#define HAVE_STATFS 1
#define HAVE_STATVFS 1
#define HAVE_STRUCT_STAT_ST_BLKSIZE 1
#define HAVE_STRUCT_STAT_ST_MTIM 1
#define HAVE_STRUCT_STAT_ST_MTIME 1
/* #undef HAVE_SYS_PSTAT_H */
#define HAVE_SYS_STATVFS_H 1
#define HAVE_SYS_STAT_H 1

I don't think conditionalizing it in configure.ac would be any benefit. The tests that are already in execution do what's necessary.