Bug 2896 - Do not fail DNS canonicalization lookup on ProxyJump
Summary: Do not fail DNS canonicalization lookup on ProxyJump
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 7.7p1
Hardware: Other Linux
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_7_9
  Show dependency tree / graph
 
Reported: 2018-08-18 20:02 AEST by Sven Wegener
Modified: 2021-04-23 14:57 AEST (History)
1 user (show)

See Also:

Attachments
openssh-proxyjump-canonicalization.patch (1.66 KB, patch)
2018-08-18 20:02 AEST, Sven Wegener 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sven Wegener 2018-08-18 20:02:41 AEST 
Created attachment 3170 [details]
openssh-proxyjump-canonicalization.patch

Currently using ProxyJump with CanonicalizeHostname set to always,
results in ssh exiting on DNS lookup failure. ProxyJump gets converted
to ProxyCommand later in the code, so both should be treated equally.
Use the direct variable, which covers both.

See the attched patch.
Comment 1 Damien Miller 2018-09-21 13:13:59 AEST 
Thanks for the patch - this has been committed and will be in the 7.9 release, due later this year.

> commit 383a33d160cefbfd1b40fef81f72eadbf9303a66 (HEAD -> master, origin/master, origin/HEAD)
> Author: djm@openbsd.org <djm@openbsd.org>
> Date:   Fri Sep 21 03:11:36 2018 +0000
> 
>     upstream: Treat connections with ProxyJump specified the same as ones
>     
>     with a ProxyCommand set with regards to hostname canonicalisation (i.e. don't
>     try to canonicalise the hostname unless CanonicalizeHostname is set to
>     'always').
>     
>     Patch from Sven Wegener via bz#2896
>     
>     OpenBSD-Commit-ID: 527ff501cf98bf65fb4b29ed0cb847dda10f4d37
Comment 2 Damien Miller 2021-04-23 14:57:39 AEST 
closing resolved bugs as of 8.6p1 release