Bug 2902 - Shellcheck reports on ssh-copy-id
Summary: Shellcheck reports on ssh-copy-id
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-copy-id (show other bugs)
Version: 7.7p1
Hardware: Other Linux
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-08-29 00:16 AEST by Jakub Jelen
Modified: 2021-04-23 15:09 AEST (History)
3 users (show)

See Also:

Attachments
proposed patches (1.67 KB, patch)
2018-08-29 00:16 AEST, Jakub Jelen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Jelen 2018-08-29 00:16:55 AEST 
Created attachment 3175 [details]
proposed patches

Running shellcheck on the ssh-copy-id results in several reports. Nothing significant that would need immediate attention, but minor fixes and cleanups:

 * Bogus argument to printf (copy&paste error)
 * It gets confused on the variable initialization on a single line without single quotes
Comment 1 Darren Tucker 2018-09-08 12:37:39 AEST 
The upstream for this is http://git.hands.com/ssh-copy-id
Comment 2 Philip Hands 2020-09-17 23:30:11 AEST 
(In reply to Jakub Jelen from comment #0)
> Running shellcheck on the ssh-copy-id results in several reports.
> ...

Thanks for the suggestion -- sorry it took me so long to get to it.

Prompted by this, I've run shellcheck on the latest version, and since it seemed sensible I've patched things to produce a quiet report.

You can see the result here:

  https://gitlab.com/phil_hands/ssh-copy-id/-/commit/f0da1a1b7d86a6254d6c234b1560e2cfafe18d58

Cheers, Phil.
Comment 3 Damien Miller 2021-04-23 15:09:17 AEST 
closing resolved bugs as of 8.6p1 release