Bug 2916 - compilation fails with openssl built without ECC
Summary: compilation fails with openssl built without ECC
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: -current
Hardware: All Linux
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_8_0
  Show dependency tree / graph
 
Reported: 2018-10-10 07:20 AEDT by cotequeiroz
Modified: 2021-03-04 09:52 AEDT (History)
1 user (show)

See Also:

Attachments
patch to fix compilation with openssl built without ECC (2.29 KB, patch)
2018-10-10 07:20 AEDT, cotequeiroz 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description cotequeiroz 2018-10-10 07:20:46 AEDT 
Created attachment 3191 [details]
patch to fix compilation with openssl built without ECC

When compiling with openssl built without ECC support, compilation fails:

In file included from openssl-compat.c:32:0: openssl-compat.h:27:10: fatal error: openssl/ecdsa.h: No such file or directory #include <openssl/ecdsa.h>

The recently-introduced ECDSA code in openssl-compat.h, and libressl-api-compat.c need to be guarded by #ifdef OPENSSL_HAS_ECC.

I've attached a patch that takes care of it.
Comment 1 Damien Miller 2018-11-09 14:28:30 AEDT 
fix applied - thanks!
Comment 2 Damien Miller 2021-03-04 09:52:21 AEDT 
close bugs that were resolved in OpenSSH 8.5 release cycle