Bug 2931 - Incorrect test against OPENSSL_VERSION_NUMBER
Summary: Incorrect test against OPENSSL_VERSION_NUMBER
Status: CLOSED DUPLICATE of bug 2921
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: 7.9p1
Hardware: All All
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-15 20:38 AEDT by David Newall
Modified: 2021-10-14 01:40 AEDT (History)
3 users (show)

See Also:

Attachments
Fix test of OPENSSL_VERSION_NUMBER (403 bytes, patch)
2018-11-15 20:38 AEDT, David Newall 		no flags Details | Diff
Test for OPENSSL_init_crypto before using (1.02 KB, patch)
2018-11-16 13:51 AEDT, Darren Tucker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Newall 2018-11-15 20:38:44 AEDT 
Created attachment 3204 [details]
Fix test of OPENSSL_VERSION_NUMBER

In openbsd-compat/openssl-compat.c, at line 79, there's a test against OPENSSL_VERSION_NUMBER which determines whether to use OPENSSL_config() or OPENSSL_init_crypto().  The test uses the latter if OpenSSL version is 1.0.1 or greater, but that function was introduced in version 1.1.0.
Comment 1 Damien Miller 2018-11-16 13:06:56 AEDT 

*** This bug has been marked as a duplicate of bug 2921 ***
Comment 2 Darren Tucker 2018-11-16 13:51:56 AEDT 
Created attachment 3206 [details]
Test for OPENSSL_init_crypto before using

I think that where possible we should be testing for the presence of the new thing (and anything else it depends on) rather than inferring it from a version number.
Comment 3 Damien Miller 2019-05-03 14:42:33 AEST 
Move resolved bugs -> CLOSED after 8.0 release
Comment 4 Ahmed Sayeed 2021-10-14 01:40:25 AEDT 
[spam removed]