Bug 2962 - client leaks ssh context, host_arg and packet.c leaks kex-structure.
Summary: client leaks ssh context, host_arg and packet.c leaks kex-structure.
Status: NEW
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 7.9p1
Hardware: All All
: P5 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-02-06 01:09 AEDT by Markus
Modified: 2019-02-22 14:53 AEDT (History)
1 user (show)

See Also:

Attachments
client_cleanup.diff (2.47 KB, application/octet-stream)
2019-02-06 01:09 AEDT, Markus 		no flags Details
fixex leaks and a problem with previous patch (sorry for the mess). (2.09 KB, patch)
2019-02-06 01:18 AEDT, Markus 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus 2019-02-06 01:09:09 AEDT 
Created attachment 3235 [details]
client_cleanup.diff

After completing the session, the client leaks the ssh structure and the host_arg.

Also, on cleanup, packet.c leaks the kex-structure (which is held inside the ssh struct).

I've also moved host_arg from global to local variable, because it is only passed to one function.

Patch is attached.
Comment 1 Markus 2019-02-06 01:18:25 AEDT 
Created attachment 3237 [details]
fixex leaks and a problem with previous patch (sorry for the mess).