Created attachment 3296 [details] Keep PRIV_PROC_SESSION for platform_pledge_mux When the SSH client is multiplexing multiple shell sessions across a single network connection to an SSH server the window change signal is not being propagated. When the ssh client code calls platform_pledge_mux() on Solaris it will call solaris_drop_privs_root_pinfo_net_exec(). This function drops too many privileges. It is supposed to be equivalent to pledge("stdio proc tty", ...) Note "proc" is kept because of the need to call kill(2). The Solaris implementation of this is currently dropping PRIV_PROC_SESSION which is needed to be able to send signals to processes the user owns but are outside of the current session. Multiple client ssh processes using the same mux are quite likely to be in different unix session groups, for example multiple panes or windows in a terminal multiplexer such as screen or tmux or mulitple xterm windows.
Pull Request: https://github.com/openssh/openssh-portable/pull/135
This is fine, but I have a couple of problems with the license change. 1) First, I don't think it is sensible to add rights-holders for a change that solely deletes code (especially a single line). 2) Second, the proposed license change "Oracle and/or its affiliates" does not unambiguously identify a rights-holder. If a user ever needed to clarify their rights or obligations with all rights-holders, there is no sure way they could determine whether they exhausted the possibilities of the "affiliates" clause. Now, #2 is moot because of #1 but it would certainly be a problem for future contributions from Oracle that include this text. I understand that it is probably your company lawyers that have stipulated this, so please feel free to pass this on. Unless you object, I'll commit the deletion part only.
No issue at all with your copyright changes, thanks.
Patch applied - thanks!
closing resolved bugs as of 8.6p1 release