Bug 3092 - Inconsistent comment / code
Summary: Inconsistent comment / code
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: 8.1p1
Hardware: Other Windows 10
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_8_2
  Show dependency treegraph
 
Reported: 2019-11-13 10:11 AEDT by balu
Modified: 2021-04-23 15:02 AEST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description balu 2019-11-13 10:11:15 AEDT
Copied the code below. The else loop does the case sensitive (3rd parameter is 0) match but the comment says it's case insensitive match.


In Match.c file

/* Match a list representing users or groups. */
int
match_usergroup_pattern_list(const char *string, const char *pattern)
{
#ifdef HAVE_CYGWIN
	/* Windows usernames may be Unicode and are not case sensitive */
	return cygwin_ug_match_pattern_list(string, pattern);
#else
	/* Case insensitive match */
	return match_pattern_list(string, pattern, 0);
#endif
}
Comment 1 Darren Tucker 2019-11-13 10:43:42 AEDT
Fixed, thanks.
Comment 2 balu 2019-11-14 11:03:14 AEDT
Did you fix the comments or the code?
Comment 3 Darren Tucker 2019-11-14 11:24:14 AEDT
Comment.  Unix usernames are case sensitive.
Comment 4 Damien Miller 2021-04-23 15:02:02 AEST
closing resolved bugs as of 8.6p1 release