Bug 3120 - Codespell report for "openssh" (on fossies.org)
Summary: Codespell report for "openssh" (on fossies.org)
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 8.2p1
Hardware: Other All
: P5 trivial
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-02-15 22:20 AEDT by Jens Schleusener
Modified: 2021-03-04 09:51 AEDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jens Schleusener 2020-02-15 22:20:10 AEDT
The FOSS server fossies.org offers a new feature "Source code misspelling reports":

 https://fossies.org/features.html#codespell

Such reports are normally only generated on request, but for testing purposes I have as Fossies administrator now done a "codespell" check for the "openssh" (portability) project:

 https://fossies.org/linux/misc/openssh/codespell.html

That version-independent URL should redirect always to the last report (if available), so currently to

 https://fossies.org/linux/misc/openssh-8.2p1.tar.gz/codespell.html

Although some obviously wrong matches ("false positives") are already filtered (ignored) please inform me if you find more of them so that I can force a new improved check if applicable.

Ok, most of the found errors are "only" in the ChangeLog file and some spelling suggestions are worth discussing, but maybe it's nevertheless meaningful to correct the few remaining ones.

Just for information there are also two supplemental pages

 https://fossies.org/linux/misc/openssh/codespell_conf.html

showing some used "codespell" configurations,

 https://fossies.org/linux/misc/openssh/codespell_fps.html

showing all resulting obvious "false positives".
Comment 1 Damien Miller 2020-03-13 14:33:52 AEDT
Thanks for passing this on. I've fixed most of the reported mistakes.

Most of the remaining ones are in the Changelog, which is automatically generated from git commit messages and not suitable for editing.

The other few are in license text that we can't change without permission from the authors. I don't plan to chase these up either - the hassle/payoff ratio is just too low.

If it's possible, it would be great if future reports excluded ChangeLog.
Comment 2 Jens Schleusener 2020-03-14 02:04:04 AEDT
So now a new codespell run was done for the current "openssh-portable" GitHub master version. The result is available via s special test folder that isn't fully integrated into the Fossies system and should not be accessible by search engines:

 https://fossies.org/linux/test/openssh-portable-master.tar.gz/codespell.html

That link should always redirect to the last analyzed GitHub master version (if a report is available), so currently to

 https://fossies.org/linux/test/openssh-portable-master.955c4cf.200313.tar.gz/codespell.html

ChangeLog files are generally "problematic" and the file was included just to point the spelling errors (it's now excluded. Also excluded was the file openbsd-compat/libressl-api-compat.c since it contains three of the mentioned errors in the license text.

If a new run seems meaningful it can be requested by a short according mail to <info@fossies.org>.
Comment 3 Damien Miller 2020-03-14 19:41:30 AEDT
Thanks, but you were a little too fast for me. I had not synched the spelling fixes in the OpenBSD tree to Portable OpenSSH. I have done so now and most of the ones listed there should be fixed.
Comment 4 Jens Schleusener 2020-03-14 21:28:16 AEDT
No problem, a new run is done and the URL

 https://fossies.org/linux/test/openssh-portable-master.tar.gz/codespell.html

redirects now to  

 https://fossies.org/linux/test/openssh-portable-master.0eaca93.200314.tar.gz/codespell.html

Wow, no spelling error are found now by codespell!
Comment 5 Darren Tucker 2020-04-24 13:23:50 AEST
Closing, thanks for the report.
Comment 6 Damien Miller 2021-03-04 09:51:38 AEDT
close bugs that were resolved in OpenSSH 8.5 release cycle