Bug 3160 - Compilation fails when DEBUG_KEXDH is defined
Summary: Compilation fails when DEBUG_KEXDH is defined
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: 8.2p1
Hardware: All All
: P5 normal
Assignee: Damien Miller
URL:
Keywords:
Depends on:
Blocks: V_8_4
  Show dependency tree / graph
 
Reported: 2020-05-06 06:55 AEST by mscdex
Modified: 2023-01-13 13:42 AEDT (History)
2 users (show)

See Also:

Attachments
fix compilation with DEBUG_KEXDH (1.13 KB, patch)
2020-05-08 13:24 AEST, Damien Miller 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mscdex 2020-05-06 06:55:16 AEST 
It seems sshd.c is referencing old packet handling functions when DEBUG_KEXDH is defined, specifically: packet_start(), packet_put_cstring(), packet_send(), and packet_write_wait(). It appears it's been this way since OpenSSH 6.8 or so.
Comment 1 Damien Miller 2020-05-08 13:24:15 AEST 
Created attachment 3391 [details]
fix compilation with DEBUG_KEXDH
Comment 2 Damien Miller 2020-05-08 15:13:31 AEST 
This has been fixed and will be in openssh-8.4
Comment 3 Damien Miller 2021-03-04 09:52:52 AEDT 
close bugs that were resolved in OpenSSH 8.5 release cycle