Bug 3237 - Regression in SSH_ASKPASS behavior
Summary: Regression in SSH_ASKPASS behavior
Status: CLOSED WORKSFORME
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 8.4p1
Hardware: Other Windows 10
: P5 minor
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-01 15:06 AEDT by Dylan Johnston
Modified: 2021-04-23 14:58 AEST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dylan Johnston 2020-12-01 15:06:22 AEDT 

    


    


      



        
          Comment 1
        

        
          Dylan Johnston

        

        
        

        
          2020-12-01 15:10:02 AEDT
        

      






Apologies in advance if there is missing information here, as I am new to OpenSSH. I'll do my best to provide as much information as possible.

Previously setting DISPLAY and SSH_ASKPASS would result in the SSH_ASKPASS program to launch when shelling to SSH.

As of 8.4p1, this is no longer the case. SSH will instead fail to launch the program defined by SSH_ASKPASS.

When I set `SSH_ASKPASS_REQUIRE` to `force`, it behaves as it did prior to 8.4p1 (launches the SSH_ASKPASS program).

    


    


      



        
          Comment 2
        

        
          Dylan Johnston

        

        
        

        
          2020-12-01 15:13:02 AEDT
        

      






I would also like to note that I am using OpenSSH via Git 2.29.2.
I am not running Git via the command line, but instead shelling to it via a graphical application.

I am calling `git clone`, which is in turn calling OpenSSH.

    


    


      



        
          Comment 3
        

        
          Damien Miller

        

        
        

        
          2020-12-01 20:50:27 AEDT
        

      






what are you setting DISPLAY to?

    


    


      



        
          Comment 4
        

        
          Dylan Johnston

        

        
        

        
          2020-12-01 21:03:56 AEDT
        

      






(In reply to Damien Miller from comment #3)
> what are you setting DISPLAY to?

Just an empty string (i.e. empty null terminated string when using CreateProcessW on Windows).

    


    


      



        
          Comment 5
        

        
          Damien Miller

        

        
        

        
          2020-12-02 08:58:40 AEDT
        

      






Recent OpenSSH check that $DISPLAY is set to a non-empty string.

if you're on Windows, then you should probably use SSH_ASKPASS_REQUIRE=force anyway because DISPLAY is nonsensical there but otherwise you can get your old setup back by setting DISPLAY to a non-empty string (anything will do).

    


    


      



        
          Comment 6
        

        
          Damien Miller

        

        
        

        
          2021-04-23 14:58:10 AEST
        

      






closing resolved bugs as of 8.6p1 release