Bug 3244 - ASAN found two memory leaks in sshd.c
Summary: ASAN found two memory leaks in sshd.c
Status: NEW
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: -current
Hardware: Other Linux
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-12-16 19:54 AEDT by filmil+mindrot
Modified: 2020-12-16 19:54 AEDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description filmil+mindrot 2020-12-16 19:54:35 AEDT 
An ASAN build of openssh-portable found the following memory leaks in sshd.c:

(1) https://github.com/openssh/openssh-portable/blob/master/sshd.c#L249: auth_opts is never freed.

(2) https://github.com/openssh/openssh-portable/blob/master/sshd.c#L2363 compat_pkgalg_proposal yields ownership of the returned "char*", which is never freed thereafter.

Not sure if y'all care about issues like these, so I wanted to check first.