Bug 3296 - Avoid possible NULL pointer dereference in monitor.c
Summary: Avoid possible NULL pointer dereference in monitor.c
Status: CLOSED WONTFIX
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 8.5p1
Hardware: Other Windows 10
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-11 14:43 AEST by Xidong Wang
Modified: 2022-02-25 13:59 AEDT (History)
1 user (show)

See Also:

Attachments
mm_answer_term() in file monitor.c (488 bytes, text/plain)
2021-04-11 14:43 AEST, Xidong Wang 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xidong Wang 2021-04-11 14:43:35 AEST 
Created attachment 3496 [details]
mm_answer_term() in file monitor.c

In function mm_answer_term() in file monitor.c, it's better to check whether pmonitor is NULL before it's dereferenced in line 1643.
Comment 1 Damien Miller 2021-04-12 17:05:04 AEST 
There should be no situations in which pmonitor can be NULL in the function, as the calling function monitor_read() references is before and after the call
Comment 2 Damien Miller 2022-02-25 13:59:07 AEDT 
closing bugs resolved before openssh-8.9