Bug 3319 - ssh -o 'IPQoS cs1' cannot overwrite IPQoS in config file
Summary: ssh -o 'IPQoS cs1' cannot overwrite IPQoS in config file
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 8.6p1
Hardware: All Linux
: P5 normal
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks: V_8_7
  Show dependency tree / graph
 
Reported: 2021-06-08 08:02 AEST by Robin Schneider
Modified: 2022-02-25 13:57 AEDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robin Schneider 2021-06-08 08:02:49 AEST 
With a ~/.ssh/config like this:

Host *
    IPQoS af21 cs1


-o cannot overwrite IPQoS anymore:


ssh -o 'IPQoS cs1' gnu.example.net -G | grep -i ipqos
ipqos af21 cs1
Comment 1 Darren Tucker 2021-06-08 17:15:57 AEST 
Confirmed, this is because the IPQoS config code does not check if the value has already been set, which allows the values from the config file to override it in readconf.c:

               if (*activep) {
                        options->ip_qos_interactive = value;
                        options->ip_qos_bulk = value2;
                }

It should also check options->ip_qos_interactive == -1.  A similar problem exists for TunnelDevice.  A fix is in the pipeline and will be in the next release.

Thanks for the report.
Comment 3 Robin Schneider 2021-06-09 03:36:58 AEST 
You are welcome. Thank you for maintaining and fixing this so quickly.
Comment 4 Damien Miller 2022-02-25 13:57:58 AEDT 
closing bugs resolved before openssh-8.9