Bug 3337 - Will OpenSSH support SMx series algorithms in the future?
Summary: Will OpenSSH support SMx series algorithms in the future?
Status: NEW
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 8.6p1
Hardware: Other Linux
: P5 enhancement
Assignee: Assigned to nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-08-10 23:55 AEST by kircher
Modified: 2021-08-11 10:22 AEST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kircher 2021-08-10 23:55:13 AEST
The support for SMx algorithms has been added by OpenSSL to the sm2, sm3, and sm4 files in the crypto directory. Does openssh have any plans to add support for these algorithms?

For example, if we want to add support for sm4-ctr, we only need to add this line to cipher.c:

{"sm4-ctr", 16, 16, 0, 0, 0, EVP_sm4_ctr},
Comment 1 Darren Tucker 2021-08-11 10:22:28 AEST
(In reply to kircher from comment #0)
> The support for SMx algorithms has been added by OpenSSL to the sm2,
> sm3, and sm4 files in the crypto directory. Does openssh have any
> plans to add support for these algorithms?

Not that I know of.  I am also not aware of any work to specify it for the SSH protocol.

> For example, if we want to add support for sm4-ctr, we only need to
> add this line to cipher.c:
> 
> {"sm4-ctr", 16, 16, 0, 0, 0, EVP_sm4_ctr},

Note that unless the cipher is defined in an SSH RFC the name needs to be a vendor extension (see RFC4251 section 6).

It's a 128 bit block cipher that's not specified for SSH. There are already several 128 bit block ciphers that are specified including one that's RECOMMENDED.  What benefit would it provide over the existing ones that would warrant maintaining it as a non-standard extension?