Bug 497 - Cleanup of including compatibility headers
Summary: Cleanup of including compatibility headers
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: -current
Hardware: All All
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-19 09:03 AEDT by Corinna Vinschen
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
openbsd header patch (1.03 KB, patch)
2003-02-19 09:05 AEDT, Corinna Vinschen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Corinna Vinschen 2003-02-19 09:03:33 AEDT 
While all headers in the openbsd-compat directory are included in
openbsd-compat/openbsd-compat.h, there are two exceptions from that
rule:

openbsd-compat/bsd-cygwin_util.h and openbsd-compat/bsd-nextstep.h
are included in includes.h which also includes openbsd-compat/openbsd-compat.h
so there's no need for that exception.

The attached patch cleans this situation up by including the affected
header files in openbsd-compat/openbsd-compat.h.
Comment 1 Corinna Vinschen 2003-02-19 09:05:04 AEDT 
Created attachment 232 [details]
openbsd header patch
Comment 2 Ben Lindstrom 2003-02-19 09:29:18 AEDT 
I don't know about Cygwin, but I originally put the NeXT stuff in that spot for 
a reason.  Unless you have a NeXT 3.3 and 4.2 machines to verify that this 
patch does not further break that platform.  I don't want it undone.
Comment 3 Corinna Vinschen 2003-02-19 18:53:34 AEDT 
In that case it makes sense to move the Cygwin bit to the correct place
at least.  I don't have a Next box (never seen any) so I can't test that.
Comment 4 Darren Tucker 2003-05-04 10:42:15 AEST 
Patch applied (for Cygwin only).  Thanks.
Comment 5 Damien Miller 2004-04-14 12:24:18 AEST 
Mass change of RESOLVED bugs to CLOSED