Bug 570 - configure --disable-FEATURE fix
Summary: configure --disable-FEATURE fix
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: -current
Hardware: All Linux
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-05-20 00:21 AEST by Roumen Petrov
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
proposed patch (2.95 KB, patch)
2003-05-20 00:24 AEST, Roumen Petrov 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roumen Petrov 2003-05-20 00:21:56 AEST 
....
- Macro: AC_ARG_ENABLE (FEATURE, HELP-STRING, [ACTION-IF-GIVEN],
[ACTION-IF-NOT-GIVEN])

If the user gave `configure' the option `--enable-FEATURE' or
`--disable-FEATURE', run shell commands ACTION-IF-GIVEN.  If neither option was
given, run shell commands ACTION-IF-NOT-GIVEN.
....
Comment 1 Roumen Petrov 2003-05-20 00:24:16 AEST 
Created attachment 306 [details]
proposed patch
Comment 2 Roumen Petrov 2003-06-27 21:46:03 AEST 
When somebody explicitly use ./configure --enable-FEATURE for one of these fixed
in proposed patch this feature is disabled.
Comment 3 Darren Tucker 2003-06-27 22:40:07 AEST 
Patch seems reasonable to me.

Unpatched:
$ ../configure --enable-lastlog
$ grep DISABLE_LAST config.h
#define DISABLE_LASTLOG 1

Patched:
$ ../configure --enable-lastlog
$ grep DISABLE_LASTLOG config.h
/* #undef DISABLE_LASTLOG */

We don't use the 3-argument AC_DEFINE*() macros at the moment, though.
Comment 4 Darren Tucker 2003-06-28 12:55:53 AEST 
Applied, apart from the 3-arg AC_DEFINE_UNQUOTED changes.  Thanks.
Comment 5 Damien Miller 2004-04-14 12:24:19 AEST 
Mass change of RESOLVED bugs to CLOSED