Bug 594 - SSH tries to set nodelay on non-sockets
Summary: SSH tries to set nodelay on non-sockets
Status: CLOSED DUPLICATE of bug 541
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: -current
Hardware: All Linux
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-17 06:20 AEST by Jim Blandy
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Blandy 2003-06-17 06:20:50 AEST
In OpenSSH 3.6.1p2, Red Hat linux 8.0:

When I ssh to a host with a proxy command, I get the following message:

$ ssh tooth.toronto.redhat.com
getsockopt TCP_NODELAY: Socket operation on non-socket

Then things work normally.

The problem seems to be that a "return;" has been deleted from the function
"packet_set_interactive" in packet.c.  The code reads:

	/* Only set socket options if using a socket.  */
	if (!packet_connection_is_on_socket())
	if (interactive)
		set_nodelay(connection_in);

The odd indentation suggests that something has gone wrong.  The logic doens't
make any sense, either: if the connection is not on a socket, then one shouldn't
try to set socket options on it.  Finally, in 3.4p1, the code reads:

	/* Only set socket options if using a socket.  */
	if (!packet_connection_is_on_socket())
		return;

So it looks to me as if the 'return;' after the call to
packet_connection_is_on_socket got accidentally deleted.
Comment 1 Ben Lindstrom 2003-06-17 06:47:31 AEST
Please search before opening bugs that have already been solved.

*** This bug has been marked as a duplicate of 541 ***
Comment 2 Damien Miller 2004-04-14 12:24:19 AEST
Mass change of RESOLVED bugs to CLOSED