Bug 612 - moduli.5 documentation doesn't match ssh code (off by 1)
Summary: moduli.5 documentation doesn't match ssh code (off by 1)
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: -current
Hardware: All All
: P2 trivial
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-07-02 22:09 AEST by william allen simpson
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description william allen simpson 2003-07-02 22:09:24 AEST 
Just discovered that ssh/dh.c interprets the /etc/moduli file in a 
slightly different way from the documentation, due to an historic 
accident (an off by 1 error) by the OpenSSH coder.  Easier to change 
the documention than the installed base ;-)

[I'm the original author, as /etc/moduli was originally used in Photuris.]
Comment 1 william allen simpson 2003-07-02 22:17:30 AEST 
[The attachment feature didn't work, at least on the web interface.]
[NetBSD patch]

Index: moduli.5
===================================================================
RCS file: /cvsroot/src/crypto/dist/ssh/moduli.5,v
retrieving revision 1.7
diff -r1.7 moduli.5
133c133
< Specifies the number of significant bits.
---
> Specifies the number of the most significant bit (0 to M).
Comment 2 Markus Friedl 2003-07-05 01:10:32 AEST 
thanks, fix for the next release.
Comment 3 Damien Miller 2004-04-14 12:24:19 AEST 
Mass change of RESOLVED bugs to CLOSED