Bug 783 - __unused nit
Summary: __unused nit
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: PAM support (show other bugs)
Version: -current
Hardware: All FreeBSD
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-01-07 00:15 AEDT by Dag-Erling Smørgrav
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
only define __unused if it isn't already defined (246 bytes, patch)
2004-01-07 00:16 AEDT, Dag-Erling Smørgrav 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dag-Erling Smørgrav 2004-01-07 00:15:21 AEDT 
auth-pam.c was originally taken from FreeBSD, which has an __unused macro which 
corresponds to GCC's __attribute__((__unused__)).  A blank definition of that 
macro was added to auth-pam.c to support platforms where it is not defined.  
This definition should be conditional on the non-existence of the macro, rather 
than unconditional.  As it stands, it causes a warning on platforms which do 
have an __unused macro.
Comment 1 Dag-Erling Smørgrav 2004-01-07 00:16:08 AEDT 
Created attachment 522 [details]
only define __unused if it isn't already defined
Comment 2 Darren Tucker 2004-01-07 12:33:56 AEDT 
Seems reasonable, but perhaps it should be moved to defines.h?
Comment 3 Darren Tucker 2004-01-08 05:33:02 AEDT 
Fixed (in defines.h).  Thanks.
Comment 4 Damien Miller 2004-04-14 12:24:20 AEST 
Mass change of RESOLVED bugs to CLOSED