Bug 91 - timeout patches
Summary: timeout patches
Status: CLOSED WONTFIX
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: -current
Hardware: ix86 Linux
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-01-31 21:29 AEDT by Matthew Vernon
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
timeout patches (work by Ian Jackson and Matthew Vernon) (13.38 KB, patch)
2002-01-31 21:31 AEDT, Matthew Vernon 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthew Vernon 2002-01-31 21:29:26 AEDT 
This patch provides protocol-level timeouts, and a timeout for the
banner-exchange too.
Comment 1 Matthew Vernon 2002-01-31 21:31:33 AEDT 
Created attachment 14 [details]
timeout patches (work by Ian Jackson and Matthew Vernon)
Comment 2 Damien Miller 2002-01-31 21:51:23 AEDT 
1. This should really be two patches - protocol keepalives are a very different
beast to connection timeouts.


2. Connection/read timeouts should use select() rather then alarm()+blocking
Comment 3 Markus Friedl 2002-01-31 22:53:19 AEDT 
please try to have one feature per patch.

1. as to protocolkeepalive: isn't this what tcp-keepalives are for?
2. why use sigaction? sshd does a similar thing, but just uses alarm()
3. why not wrap exchange_indentification into alarm, like sshd does?
4. not all ssh1 implementations will accept your ignore message
Comment 4 Damien Miller 2003-05-24 11:07:26 AEST 
See also bug #207
Comment 5 Damien Miller 2003-06-04 21:58:33 AEST 
The patch here has been partially obsoleted by the ConnectTimeout feature in
CVS. The other change (banner exchange timeout) has bitrotted and the authors
haven't responded in over a year.

If someone wants to do a new banner exchange timeout patch, please make a new
bug. Such a patch should use the time remaining from ConnectTimeout for the
banner exchange, rather than adding a new option.
Comment 6 Damien Miller 2004-04-14 12:24:17 AEST 
Mass change of RESOLVED bugs to CLOSED