Bug 927 - Last login displayed even when .hushlogin exists
Summary: Last login displayed even when .hushlogin exists
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: -current
Hardware: SPARC Solaris
: P2 trivial
Assignee: OpenSSH Bugzilla mailing list
URL: http://marc.theaimsgroup.com/?l=opens...
Keywords:
Depends on:
Blocks:
 
Reported: 2004-09-10 08:12 AEST by Tait
Modified: 2006-10-07 11:37 AEST (History)
0 users

See Also:


Attachments
Check quietlogin before displaying last message (575 bytes, patch)
2004-09-11 15:20 AEST, Darren Tucker
djm: ok+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tait 2004-09-10 08:12:16 AEST
With OpenSSH_3.5p1, The "Last login: <date> from <host>" was not displayed if
the user had .hushlogin in their homedir. With OpenSSH_3.9p1, this line is
displayed despite the .hushlogin.
Comment 1 Darren Tucker 2004-09-11 15:15:19 AEST
Yes, this is a bug introduced with some code intended to display the output of
PAM session modules and was reported recently (see URL).  Will attach a patch.
Comment 2 Darren Tucker 2004-09-11 15:20:13 AEST
Created attachment 712 [details]
Check quietlogin  before displaying last message

As noted in the URL, it would be better to cache the return value of
check_quietlogin(), however this would mean changing some of the platform
independant code.

That would represent more of an ongoing maintenance overhead (ie patches from
OpenBSD won't apply to the changed parts) so as a rule we try to keep the
-portable changes clustered together).
Comment 3 Damien Miller 2004-09-11 18:54:08 AEST
Comment on attachment 712 [details]
Check quietlogin  before displaying last message

This looks OK
Comment 4 Darren Tucker 2004-09-11 23:10:17 AEST
Applied, thanks.
Comment 5 Darren Tucker 2006-10-07 11:37:02 AEST
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.